Add polling and reload callback for extensions. #8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On reload callback is fine (although the demo argument is not needed since you don't use it, and I think it's more reasonable to call it after demo.close()), but the other one should not be there. If you want some periodic events, make a thread and do that there, with whatever interval you like. |
AUTOMATIC1111
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
Add a polling and reload callback that extensions can use.
Additional notes and description of your changes
I've made a telegram bot extension for Automatic1111 that uses this , I use the polling provided by this PR to poll telegram updates, which simplifies this kind of usage to all extensions.
Environment this was tested in
Screenshots or videos of your changes
Since it's a functionality to be used by extensions, no videos are provided.