Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add extrastab send to img2img #899

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

S-Tubasa
Copy link
Contributor

Refs #849
Added send to img2img for extrastab

@AUTOMATIC1111
Copy link
Owner

why not also send to inpaint then

@S-Tubasa
Copy link
Contributor Author

S-Tubasa commented Sep 23, 2022

Try is #859
Should we delete here

tabs.change(
fn=lambda x: x,
inputs=[init_img_with_mask],
outputs=[init_img_with_mask],
)
tabs_img2img_mode.change(
fn=lambda x: x,
inputs=[init_img_with_mask],
outputs=[init_img_with_mask],
)

Why is this code necessary?

@AUTOMATIC1111
Copy link
Owner

oh no, that stays, this is what makes it possible to recover from the gradio bug with inpainting where it just stops working when you switch tabs with an image loaded.

gradio-app/gradio#2224

@AUTOMATIC1111 AUTOMATIC1111 merged commit 03faf20 into AUTOMATIC1111:master Sep 23, 2022
@S-Tubasa
Copy link
Contributor Author

S-Tubasa commented Sep 23, 2022

P.S.
tabs_img2img_mode.change and tabs.change triggered this errors(#859)
image

gradio-app/gradio#2224 is solve for gradio-app/gradio#2144

This need to delete here.

tabs.change(
fn=lambda x: x,
inputs=[init_img_with_mask],
outputs=[init_img_with_mask],
)
tabs_img2img_mode.change(
fn=lambda x: x,
inputs=[init_img_with_mask],
outputs=[init_img_with_mask],
)

nne998 pushed a commit to fjteam/stable-diffusion-webui that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants