Refactor/bsk 321 denton flux module

[JulianHammerl]

• Tickets addressed: Refactor Denton Flux Module #321
• Review: By commit
• Merge strategy: Merge (no squash)

Description

The particle flux units were changed from [cm^-2 s^-1 sr^-2 eV^-1] to [m^-2 s^-1 sr^-2 eV^-1]. This required changes in the PlasmaFluxMsg message and the DentonFluxModel module. The code was cleaned cleaned up along to way, whatever caught my eye.

Verification

The existing UnitTest was updated to reflect the changes and still passes.

Documentation

No .rst documentation was invalidated. The comments in the PlasmaFluxMsg message and the DentonFluxModel module files. were updated accordingly to reflect the change in units

Future work

None expected at this point.

[juan-g-bonilla]

@JulianHammerl linux test errors are due to #313, so don't worry about them . Strange that all tests passed in that PR but not now. Will fix soon, sorry.

[schaubh]

Needs to add release notes explaining the change in units in this message.

[schaubh]

should be good to go.

[leahkiner]

This looks good! My only feedback is that you can remove the constructor and destructor definitions in the dentonFluxModel.cpp and simply add = default into the header file definitions if you want the code to be more minimal. But that's not necessary!