Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2 dof scenario #403

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Feature/2 dof scenario #403

merged 4 commits into from
Aug 2, 2023

Conversation

joaogvcarneiro
Copy link
Contributor

Description

A scenario that uses the 2-DoF spinning bodies module was added. It can use one or two panels, and the module is set up accordingly. A comprehensive Vizard simulation is also set up.

Verification

A scenario test file was added, which parameterizes the number of panels.

Documentation

No documentation was invalidated. A short description of the scenario is given.

Future work

@joaogvcarneiro joaogvcarneiro added the enhancement New feature or request label Aug 1, 2023
@joaogvcarneiro joaogvcarneiro self-assigned this Aug 1, 2023
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few fixes, including:

  • added the scenario to the examples folder _default.rst file
  • fixed typos in the SVG file names, "2" versus "Two"
  • small scenario edits
    I marked the changes to the script with [squash] in the commit so you can squash them with your original commit after reviewing them. Good to go then.

@joaogvcarneiro joaogvcarneiro merged commit aaceaf9 into develop Aug 2, 2023
2 checks passed
@joaogvcarneiro joaogvcarneiro deleted the feature/2_dof_scenario branch August 2, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants