fix issue with scenario script writing Viz binary by default #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
approved these changes
Nov 17, 2023
joaogvcarneiro
approved these changes
Nov 17, 2023
schaubh
force-pushed
the
feature/fix_viz_saving
branch
from
046aee3
to
38c6d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BSK scenario scripts are setup to save off the simulation data to a Vizard binary file. However,
the script should have the file saving turned off by default. I found a file that didn't do this. As a result,
every time we run our complete unit test suite a Vizard binary file was being created and saved off. This
PR fixes this.
Verification
Did a clean build, removed prior
_VizFilesfolder and didn't see the Vizard binary file being saved off by default.Documentation
None
Future work
None