Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accumulated dv inertial frame #513

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

joaogvcarneiro
Copy link
Contributor

Description

The first commit adds the new field into scStatesMasgPayload. The second commit populates the new message field in the spacecraft module. The third adjusts the unit test to go through this new field.

Verification

Unit test is updated to test out the new parameter.

Documentation

N/A.

Future work

N/A.

@joaogvcarneiro joaogvcarneiro added the enhancement New feature or request label Nov 29, 2023
@joaogvcarneiro joaogvcarneiro self-assigned this Nov 29, 2023
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test is not comprehensive, otherwise good now.

Copy link
Contributor

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

@joaogvcarneiro joaogvcarneiro force-pushed the feature/accumulated-dv-inertial-frame branch from a660579 to 1febead Compare December 7, 2023 21:24
@joaogvcarneiro joaogvcarneiro force-pushed the feature/accumulated-dv-inertial-frame branch from 1febead to 66abbd3 Compare December 7, 2023 21:54
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@schaubh schaubh force-pushed the feature/accumulated-dv-inertial-frame branch from 66abbd3 to 2585910 Compare December 8, 2023 14:27
@schaubh schaubh merged commit a80b1d8 into develop Dec 8, 2023
2 checks passed
@schaubh schaubh deleted the feature/accumulated-dv-inertial-frame branch December 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add accumulated dv of spacecraft's center of mass in inertial frame components
3 participants