-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accumulated dv inertial frame #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit test is not comprehensive, otherwise good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired
src/simulation/dynamics/spacecraft/_UnitTest/test_spacecraft.py
Outdated
Show resolved
Hide resolved
a660579
to
1febead
Compare
1febead
to
66abbd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
The new field corresponds to the accumulated delta-v of the center of mass of the spacecraft in the inertial frame.
66abbd3
to
2585910
Compare
Description
The first commit adds the new field into scStatesMasgPayload. The second commit populates the new message field in the spacecraft module. The third adjusts the unit test to go through this new field.
Verification
Unit test is updated to test out the new parameter.
Documentation
N/A.
Future work
N/A.