Correct windows debug build flags #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/windows-debug-build
branch
from
d4dcea3
to
891600a
Compare
patkenneally
force-pushed
the
feature/windows-debug-build
branch
from
891600a
to
b399ed6
Compare
patkenneally
force-pushed
the
feature/windows-debug-build
branch
from
b61a81b
to
94137c4
Compare
joaogvcarneiro
approved these changes
Dec 7, 2023
patkenneally
force-pushed
the
feature/windows-debug-build
branch
from
94137c4
to
b7a242e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The windows library build tag flags are being overridden by a string replace setting all build targets to not build with debug flags (/MDd, /MTd) when a debug build is triggered. Any debug build would not have been a true debug build as the built libraries weren't built for debug. The flag replacement have been separated into a choice between Debug and every other build profile (because the builds system doesn't properly handle other build profiles like RelWithDebInfo and MinSizeRel). This PR also updates documentation for install python on windows showing what addition installation options should be selected to be able to carry out a Debug build.
Verification
This was built and run on a Windows system.
Documentation
Update windows python installation recommendations in docs.
Future work
Ideally large changes to the build system need to occur. I'm digging into this.