Update basilisk python check for 3 8 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
added
bug
schaubh
approved these changes
Dec 7, 2023
patkenneally
force-pushed
the
feature/update-basilisk-python-check-for-3-8
branch
from
dc27145
to
ea8e392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work updates the CMakeList and conanfile to check for 3.8. There is no real value in trying to support 3.7 (no ability to provide type hints which is the main feature which causes 3.7 to fail). Further 3.7 is now end-of-life. For reference https://devguide.python.org/versions/
Verification
CI should run as expected.
Documentation
Documentation has been updated.
Future work
NA