Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walker Delta Constellation Scenario #539

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

andrewmorell
Copy link
Contributor

  • Tickets addressed: N/A
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

One commit introduces a new Basilisk example script which demonstrates the setup of a Walker-Delta constellation. This scenario uses the stand alone Basilisk implementation rather than the MultiSatBskSim framework.

Verification

The default inputs model the Galileo navigation constellation with Walker-Delta numbers of 56-24-3-1. The corresponding ground track is plotted for the 24 satellites. Simulation in Vizard was also used and documented to verify expected functionality.

Documentation

This scenario was added to the list of formation flying integrated example scripts in examples/_default.rst as well as introduced to the release notes.

Future work

N/A

@schaubh schaubh self-requested a review December 13, 2023 20:04
@schaubh schaubh self-assigned this Dec 13, 2023
@schaubh schaubh added the enhancement New feature or request label Dec 13, 2023
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some edits to this branch. Please merge them into your main document. You can see in each commit what I did.

  • The scenario script did not run as committed as it was trying to read in an image that is not included. I removed this image import, not needed.
  • The Vizard visualization of this simulation is really cool! Thanks for doing that.
  • The scenario script does not get run using pytest. I added a unit test for this script in src/tests.
  • I added the missing Vizard screen grab that your documentation was trying to load. Such images must be put in the static images folder.

Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go. Nice scenario of doing complex constellation simulation.

Includes documentation, unit test and release notes
@schaubh schaubh force-pushed the feature/constellationScenario branch from a6f167a to 1fbc7c5 Compare December 15, 2023 02:30
@schaubh schaubh merged commit 540c75f into develop Dec 15, 2023
2 checks passed
@schaubh schaubh deleted the feature/constellationScenario branch December 15, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants