Feature/498 add srp effector facet articulation #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahkiner
force-pushed
the
feature/498-add-srp-effector-facet-articulation
branch
from
0b855ad
to
0ce149e
Compare
schaubh
requested changes
Dec 16, 2023
There was a problem hiding this comment.
Almost there. I added some comments to address. Please add back the code in Reset that checked that required input messages are connected. I also pushed some small fixes to this branch. You can review these fixes and squash the commits with the earlier commits.
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.cpp
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.h
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.rst
Show resolved
Hide resolved
leahkiner
force-pushed
the
feature/498-add-srp-effector-facet-articulation
branch
4 times, most recently
from
944e893
to
bc01496
Compare
These changes include renaming variables, editing comments, and moving lines of code to more logical locations
leahkiner
force-pushed
the
feature/498-add-srp-effector-facet-articulation
branch
2 times, most recently
from
5da8a6f
to
3fd26e5
Compare
The SepMomentumManagement scenario must also be refactored to run with the new changes
schaubh
force-pushed
the
feature/498-add-srp-effector-facet-articulation
branch
from
3fd26e5
to
4eb0587
Compare
schaubh
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the
facetSRPDynamicEffectormodule and adds optional facet articulation to the moduleVerification
The unit test is adjusted to calculate the correct SRP force and torque values for the articulated facets
Documentation
The module documentation is updated to reflect these additions
Future work
N/A