simIncludeRW didn't allow specify certain RW friction parameters #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before these properties were over-written if the RW template specified them. Now they are either defaulting to zero if nobody specifies them, set to the RW template value if only the template is used, and set to the specific value if the user wants to.
andrewmorell
approved these changes
Sep 21, 2024
src/simulation/dynamics/reactionWheels/_UnitTest/test_reactionWheelStateEffector_integrated.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
simIncludeRW.pythe user can specify customfCoulomb,fStaticandcViscousvalues. However, if the RW templates also specify these the custom values were overwritten.Verification
All tests pass. Expanded RW unit test to check if a custom friction value is set and retained.
Documentation
Updated release notes and known issues document.
Future work
None