Fix RPATH when installing from source for macOS #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think there is any mechanism where the change could have possibly affected Linux opNav, so I think the CI failure was caused by some flaky test timing out. |
|
@sassy-asjp , I agree that this looks like a time-out issue. For the life of me I can't figure out why some test runs stall at different places and then time out occasionally. This started happening when I added additional tests to be run. It isn't the same run that times out, and not always at the same place. For now I simply re-run the tests that time out. Not ideal, I agree. |
Required for installing from sdist/tarball/git-link
schaubh
added
bug
|
I was able to test this on my macOS laptop and it worked. I added updated documentation and release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipinstall from source due to hard-coded RPATH #826Description
The fix described in #826 which guesses the correct RPATH (similar to how it works on Linux) was implemented.
Verification
Tested:
Documentation
None
Future work
None