Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPICE module to scenarioOrbitManeuver scenario #834

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add SPICE module to scenarioOrbitManeuver scenario #834

merged 1 commit into from
Oct 22, 2024

Conversation

jackfox25
Copy link
Contributor

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Adding spice module into scenarioOrbitManeuver.py scenario, to enable Earth rotation

Verification

Manual testing, Earth spinning in Vizard. Matches implementation in scenarioSpiceSpacecraft.py

Documentation

No updates

Future work

None

@jackfox25 jackfox25 added the enhancement New feature or request label Oct 21, 2024
@jackfox25 jackfox25 requested a review from a team as a code owner October 21, 2024 18:43
schaubh
schaubh requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about the custom spice kernel include? I think these lines can be removed.

need to add release notes that this script has been updated.

examples/scenarioOrbitManeuver.py Outdated Show resolved Hide resolved
examples/scenarioOrbitManeuver.py Outdated Show resolved Hide resolved
@jackfox25 jackfox25 force-pushed the feature/add_spice_to_scenario branch from bfc433f to b8a68fa Compare October 22, 2024 15:17
jackfox25
jackfox25 commented Oct 22, 2024
View reviewed changes
Copy link
Contributor Author

@jackfox25 jackfox25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the custom kernel, added release notes

schaubh
schaubh approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@jackfox25 jackfox25 merged commit d7d9f72 into develop Oct 22, 2024
9 checks passed
@jackfox25 jackfox25 deleted the feature/add_spice_to_scenario branch October 22, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaubh schaubh schaubh approved these changes

Assignees

@schaubh schaubh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackfox25 @schaubh