Allow Output to ignore @transientDefault #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th IgnoreTransientDefaultMarker
halotukozak
requested changes
Sep 25, 2024
core/src/main/scala/com/avsystem/commons/serialization/macroCodecs.scala
Show resolved
Hide resolved
core/src/test/scala/com/avsystem/commons/serialization/cbor/CborInputOutputTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/com/avsystem/commons/serialization/cbor/CborInputOutputTest.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/avsystem/commons/serialization/customMarkerWrappers.scala
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Show resolved
Hide resolved
macros/src/main/scala/com/avsystem/commons/macros/serialization/GenCodecMacros.scala
Outdated
Show resolved
Hide resolved
|
LGTM |
halotukozak
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
IgnoreTransientDefaultMarkerthat allowsOutputimplementation to instructGenCodecinstance to ignore@transientDefaultannotation on case class fields and serialize all fields even when field value is equal to it's default value.Allowing this behaviour can be helpful when using the same model class in multiple contexts with different serialization
formats that have conflicting requirements for handling default values.