New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index.ts async first #4

Open

AVaksman wants to merge 1 commit into master from index_async-first

Owner

AVaksman commented Mar 4, 2019

getEntries() and getSinks() are not converted as I am waiting for paginator PR to land -> get a new release

Refactor to async-first with callbackifyAll
- Currently logging.request uses callback to differentiate between making callbackRequest and
  streamRequest'. But now presence of callback will be a flag for callbackify`

As such

Refactor methods to call gax client methods directly.
- To solve above mentioned issue.
- For readability.


          index.ts to async-first

d24868e

AVaksman force-pushed the index_async-first branch from 38a5d0e to d24868e Compare

March 4, 2019 22:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet