-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: date range support for sql reports #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwwinter
force-pushed
the
tw/feat/2239-sql-reports-support
branch
from
June 7, 2024 13:15
a7b41ed
to
f44221f
Compare
tomwwinter
force-pushed
the
tw/feat/2239-sql-reports-support
branch
from
June 7, 2024 13:25
f44221f
to
d4d821e
Compare
sleidig
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I am not clear about the effects of a few of the changes.
Is there a deployed system for testing?
...rvice/src/main/kotlin/com/aamdigital/aambackendservice/reporting/domain/ReportCalculation.kt
Outdated
Show resolved
Hide resolved
...ital/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt
Outdated
Show resolved
Hide resolved
...com/aamdigital/aambackendservice/reporting/reportcalculation/core/DefaultReportCalculator.kt
Outdated
Show resolved
Hide resolved
application/aam-backend-service/src/main/resources/application.yaml
Outdated
Show resolved
Hide resolved
application/aam-backend-service/src/test/resources/database/documents/ReportConfig:2.json
Outdated
Show resolved
Hide resolved
3 tasks
3 tasks
sleidig
reviewed
Jul 23, 2024
...ervice/src/main/kotlin/com/aamdigital/aambackendservice/couchdb/core/DefaultCouchDbClient.kt
Outdated
Show resolved
Hide resolved
sleidig
approved these changes
Jul 23, 2024
...rvice/src/main/kotlin/com/aamdigital/aambackendservice/reporting/domain/ReportCalculation.kt
Outdated
Show resolved
Hide resolved
.../com/aamdigital/aambackendservice/reporting/report/core/DefaultReportCalculationProcessor.kt
Outdated
Show resolved
Hide resolved
...com/aamdigital/aambackendservice/reporting/reportcalculation/core/DefaultReportCalculator.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/aamdigital/aambackendservice/reporting/domain/event/DocumentChangeEvent.kt
Outdated
Show resolved
Hide resolved
...ital/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt
Outdated
Show resolved
Hide resolved
...ital/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt
Outdated
Show resolved
Hide resolved
...ital/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian <[email protected]>
…/aambackendservice/reporting/domain/event/DocumentChangeEvent.kt Co-authored-by: Sebastian <[email protected]>
…/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt Co-authored-by: Sebastian <[email protected]>
…/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt Co-authored-by: Sebastian <[email protected]>
…/aambackendservice/reporting/reportcalculation/controller/ReportCalculationController.kt Co-authored-by: Sebastian <[email protected]>
# Conflicts: # application/aam-backend-service/src/main/resources/application.yaml
sleidig
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.