Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

fix: update activeReports before checking changes #39

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: update activeReports before checking changes #39

wants to merge 1 commit into from

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Feb 28, 2024

  • still to be tested in full environment (with couchdb)

sleidig
sleidig commented Feb 28, 2024
View reviewed changes
src/report-changes/core/report-changes.service.ts
Comment on lines +110 to +113
switchMap((change: DocChangeDetails) =>
// await an update of monitors for currently active reports
from(this.updateReportMonitors()).pipe(map(() => change)),
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also do a deeper refactoring and remove the ChangeDetector instances completely. But the underlying bug should be fixed ASAP, so I kept that as is for now.

@sleidig sleidig added the Status: Core Team Priority Prioritized tasks that will be handled by the core team. (Community volunteers, please do not pick) label Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomwwinter tomwwinter Awaiting requested review from tomwwinter

Assignees
No one assigned
Labels
Status: Core Team Priority Prioritized tasks that will be handled by the core team. (Community volunteers, please do not pick)
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sleidig