Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In release mode, the icons cannot be displayed properly #99

Closed
Tracked by #102
xyeie opened this issue May 9, 2024 · 14 comments · Fixed by #102
Closed
Tracked by #102

In release mode, the icons cannot be displayed properly #99

xyeie opened this issue May 9, 2024 · 14 comments · Fixed by #102
Assignees
@AathifMahir
Labels
Area-Core Area-Extensions Bug Something isn't working

Comments

@xyeie
Copy link

xyeie commented May 9, 2024

Describe the bug
In release mode, the icons cannot be displayed properly。In debug mode, everything works fine

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
null
@AathifMahir
Copy link
Owner

Describe the bug
In release mode, the icons cannot be displayed properly。In debug mode, everything works fine

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
null

Would you mind sharing which platform that your building for?

@xyeie
Copy link
Author

xyeie commented May 9, 2024

sorry my english is poor.Let me briefly describe it. The IDE version is Visual Studio2022 17.9.6, Maui version 8.0, platform pixel4, android13

@xyeie
Copy link
Author

xyeie commented May 9, 2024

工单1
工单2

@AathifMahir
Copy link
Owner

AathifMahir commented May 9, 2024 •
edited
Loading

I'll try to reproduce this as soon as possible and get back to you @xyeie

@AathifMahir AathifMahir self-assigned this May 11, 2024
@AathifMahir
Copy link
Owner

@xyeie You can rollback the version of MauiIcons v2.1.5, I found that new binding feature that introduced in v2.2.5 Causing this Issue in Release Mode, I Already Flagged the Build, Will have a Patch for this As soon as Possible

@AathifMahir AathifMahir mentioned this issue May 11, 2024
Merged
3 tasks
@AathifMahir AathifMahir linked a pull request May 11, 2024 that will close this issue
vNext with TFM Update and Fixes #102
Merged
3 tasks
@AathifMahir
Copy link
Owner

AathifMahir commented May 11, 2024 •
edited
Loading

Fixed in #102

@xyeie Update MauiIcons to v3 and Let me know, if your still facing the same

@xyeie
Copy link
Author

xyeie commented May 11, 2024

good job! everything is fine! thanks

@rcanacci
Copy link

@xyeie You can rollback the version of MauiIcons v2.1.5, I found that new binding feature that introduced in v2.2.5 Causing this Issue in Release Mode, I Already Flagged the Build, Will have a Patch for this As soon as Possible

Aathif,

This problem is still present in v2.1.5.

Under all other deployment combinations (iOS debug/release, Android debug/release, and Windows debug) the icons work without issue.

Only present under Window release build.

Also - please note that versions 2.2.5 and 3.0.0 I tried both of these as a workaround within my MAUI app. Both versions break the icons totally. Version 2.1.5 is the only one that works properly. Unless there are missing steps for proper installation on your github homepage for this project.

We have been using your icon set for months but these two problems persist:

  • (IMPORTANT) we cannot build for Windows release mode with the icons, they display as rectangles.
  • We cannot update past v2.1.5; breaks every icon within our XAML code.

Thank you in advance for any help.
This problem preventing us from deploying our app.

icons-not-displaying-example

@AathifMahir
Copy link
Owner

AathifMahir commented May 12, 2024 •
edited
Loading

@xyeie You can rollback the version of MauiIcons v2.1.5, I found that new binding feature that introduced in v2.2.5 Causing this Issue in Release Mode, I Already Flagged the Build, Will have a Patch for this As soon as Possible

Aathif,

This problem is still present in v2.1.5.

Under all other deployment combinations (iOS debug/release, Android debug/release, and Windows debug) the icons work without issue.

Only present under Window release build.

Also - please note that versions 2.2.5 and 3.0.0 I tried both of these as a workaround within my MAUI app. Both versions break the icons totally. Version 2.1.5 is the only one that works properly. Unless there are missing steps for proper installation on your github homepage for this project.

We have been using your icon set for months but these two problems persist:

  • (IMPORTANT) we cannot build for Windows release mode with the icons, they display as rectangles.
  • We cannot update past v2.1.5; breaks every icon within our XAML code.

Thank you in advance for any help.
This problem preventing us from deploying our app.

icons-not-displaying-example

I have tested release build on All the Platforms on v3.0.0 everything worked fine except Unpackaged Windows App which had issue on Maui itself #79

Can you elaborate what do you mean by that you can't update past v2.1.5 that breaks all the icons? Breaks icons in the sense would you mind explaining that and also if you can please share a code snippet of breaking icons

Additionally, you can build and try MauiIcons.Sample which is what we are using for testing purpose

@rcanacci
Copy link

rcanacci commented May 12, 2024 via email

@AathifMahir
Copy link
Owner

AathifMahir commented May 12, 2024 •
edited
Loading

Yes, I am using Unpackaged.

So, you would suggest a different icon library?

On Sun, May 12, 2024 at 1:04 AM AathifMahir @.***>
wrote:

@xyeie https://github.com/xyeie You can rollback the version of
MauiIcons v2.1.5, I found that new binding feature that introduced in
v2.2.5 Causing this Issue in Release Mode, I Already Flagged the Build,
Will have a Patch for this As soon as Possible

Aathif,

This problem is still present in v2.1.5.

Under all other deployment combinations (iOS debug/release, Android
debug/release, and Windows debug) the icons work without issue.

Only present under Window release build.

Also - please note that versions 2.2.5 and 3.0.0 I tried both of these as
a workaround within my MAUI app. Both versions break the icons totally.
Version 2.1.5 is the only one that works properly. Unless there are missing
steps for proper installation on your github homepage for this project.

We have been using your icon set for months but these two problems persist:

  • (IMPORTANT) we cannot build for Windows release mode with the icons,
    they display as rectangles.
  • We cannot update past v2.1.5; breaks every icon within our XAML code.

Thank you in advance for any help.
This problem preventing us from deploying our app.

icons-not-displaying-example.png (view on web)
https://github.com/AathifMahir/MauiIcons/assets/8365271/6c1e402b-99e1-413b-bb2e-59f923234908

I have tested release build on All the Platforms on v3.0.0 everything
worked fine except Unpackaged Windows App which had issue on Maui itself

—
Reply to this email directly, view it on GitHub
#99 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB72JV6ROCXDIVGBNVQS77LZB3Z5BAVCNFSM6AAAAABHOOBHAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEZDAMBYGQ
.
You are receiving this because you commented.Message ID:
@.***>

You can try upgrading Maui to v8.0.21, whether that fixed the issue. If not you need to convert icons one by one to SVG to solve this issue. As far as now we can't use icon as fonts in Unpackaged until this issue is resolved

This issue seems to be fixed v8.0.14 but some users still report that the issue is still exist, therefore now trying the latest Maui Version is only option, if your lucky enough you'd have this working
dotnet/maui#15802

@rcanacci
Copy link

rcanacci commented May 12, 2024 via email

@AathifMahir
Copy link
Owner

Aathif,

thank you for the discussion back-and-forth… I tried a few things that you
suggested… None of them are working… Based on your Maui experience and some
of the other things that I've been reading… Is it fair to say that
Microsoft is just not truly supporting the unpackaged building and
publishing of a MAUI app?

Should I invest my time pursuing another avenue, like MSIX?

Ron

On Sun, May 12, 2024 at 1:32 AM AathifMahir @.***>
wrote:

Yes, I am using Unpackaged.

So, you would suggest a different icon library?

On Sun, May 12, 2024 at 1:04 AM AathifMahir @.***>
wrote:

@xyeie https://github.com/xyeie https://github.com/xyeie You can
rollback the version of
MauiIcons v2.1.5, I found that new binding feature that introduced in
v2.2.5 Causing this Issue in Release Mode, I Already Flagged the Build,
Will have a Patch for this As soon as Possible

Aathif,

This problem is still present in v2.1.5.

Under all other deployment combinations (iOS debug/release, Android
debug/release, and Windows debug) the icons work without issue.

Only present under Window release build.

Also - please note that versions 2.2.5 and 3.0.0 I tried both of these as
a workaround within my MAUI app. Both versions break the icons totally.
Version 2.1.5 is the only one that works properly. Unless there are missing
steps for proper installation on your github homepage for this project.

We have been using your icon set for months but these two problems persist:

  • (IMPORTANT) we cannot build for Windows release mode with the icons,
    they display as rectangles.
  • We cannot update past v2.1.5; breaks every icon within our XAML code.

Thank you in advance for any help.
This problem preventing us from deploying our app.

icons-not-displaying-example.png (view on web)

https://github.com/AathifMahir/MauiIcons/assets/8365271/6c1e402b-99e1-413b-bb2e-59f923234908

I have tested release build on All the Platforms on v3.0.0 everything
worked fine except Unpackaged Windows App which had issue on Maui itself

—
Reply to this email directly, view it on GitHub
#99 (comment)
#99 (comment)
,
or unsubscribe

https://github.com/notifications/unsubscribe-auth/AB72JV6ROCXDIVGBNVQS77LZB3Z5BAVCNFSM6AAAAABHOOBHAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEZDAMBYGQ
.
You are receiving this because you commented.Message ID:
@.***>

You can try upgrading Maui to v8.0.21, whether that fixed the issue. If
not you need to convert icons one by one to SVG to solve this issue. As far
as now we can't use icon as fonts in Unpackaged until this issue is resolved

—
Reply to this email directly, view it on GitHub
#99 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB72JV4MZ7QX5MBDFGPSNV3ZB35FLAVCNFSM6AAAAABHOOBHAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEZDKNBWGM
.
You are receiving this because you commented.Message ID:
@.***>

I'm can't certainly say Microsoft left out Unpackaged, But when it comes this issue, this is directly related Win2D Component of Windows App SDK but When it comes Choosing Between Unpackaged vs MSIX, I would say it's based on your Pros and Cons, What Makes Unpackaged Way to do go for you is What Decides whether to Go with MSIX or not

@rcanacci
Copy link

rcanacci commented May 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AathifMahir AathifMahir

Labels
Area-Core Area-Extensions Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vNext with TFM Update and Fixes AathifMahir/MauiIcons
3 participants
@rcanacci @AathifMahir @xyeie