Private pool #37
Open
Private pool #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 27, 2021 03:43
Kashi pair with the following changes: - Charge protocol fee on liquidations - Charge protocol fee on borrow open - Allow only one lender, and a whitelist of borrowers - Collect fees as soon as feasible; do not "reinvest" - Add option to seize collateral on liquidation. Bonus and fees are taken out in the collateral as well - Add expiration (liquidation-free period)
0xm3rlin
commented
Dec 6, 2021
contracts/PrivatePool.sol
Outdated
|
|
||
| AccrueInfo memory _accrueInfo = accrueInfo; | ||
| require( | ||
| block.timestamp >= _accrueInfo.NO_LIQUIDATIONS_BEFORE, |
There was a problem hiding this comment.
I think if we still have an oracle we still need a liquidation if it goes insolvent, it should just also liquidate if the time period is up
There was a problem hiding this comment.
after the time period is up, liquidations should be possible even if the position is still solvent.
added 13 commits
December 10, 2021 04:20
This reverts commit ae063b3.
cryptolyndon
force-pushed
the
private-pool
branch
from
6bfb5f5
to
643a85a
Compare
added 2 commits
December 26, 2021 13:50
Notable features/differences: - Same lender / borrowers model as PrivatePool - ERC-721 contract as collateral - One loan per contract token - Interest auto-compounds; no accrue() - Repayment can only be in full - Open fee comes out of principal - Lender can update loan parameters. If a loan is currently taken out then the update succeeds as long as it benefits the borrower. - No "flash borrows". (Would probably use a separate borrow function). - Expirations are required, and collateral gets auto-seized by the lender on expiration. Other than that, no liquidations.
added 11 commits
June 6, 2022 05:49
cryptolyndon
force-pushed
the
private-pool
branch
from
6624413
to
8e41876
Compare
Dwatrack05
approved these changes
Jun 16, 2022
Dwatrack05
approved these changes
Jun 16, 2022
Dwatrack05
approved these changes
Jun 16, 2022
0xCalibur
reviewed
Jul 12, 2022
| // Cast is safe: No loan will be active if this overflows | ||
| uint256 interest = calculateInterest(params.valuation, uint64(block.timestamp - loan.startTime), params.annualInterestBPS); | ||
| uint256 amount = params.valuation + interest; | ||
| (bool ok, uint256 rate) = params.oracle.get(address(this), tokenId); |
There was a problem hiding this comment.
Would it be better to pass the address of the collateral instead of address(this)?
|
|
||
| // Protect tokens that are underwater to begin with from being "lent" | ||
| // against (and seized immediately): | ||
| if (params.oracle != INFTOracle(0)) { |
There was a problem hiding this comment.
should params.oracle be really optional? otherwise I think it's fair to also "nullcheck" it in remove collateral as well?
cryptolyndon
force-pushed
the
private-pool
branch
from
0c6899b
to
6ec5a2e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.