Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/root pom 15 multi arch builds #16

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Jul 17, 2023

Fixes #15

  • Introduce a new property docker.platforms that enable multi-platform builds. Change the maven-docker-plugin config accordingly.
  • Add renamed aliases docker. for the existing properties dockerfile.*, and deprecate the later ones for brevity and consistency reasons. Backward compatibility with the existing client POMs is preserved.
  • Add a forked copy of the docker plugin to fix an auth issue on docker.io (see Buildx: insufficient_scope: authorization failed fabric8io/docker-maven-plugin#1688). This change is likely temporary, until the PR is merged into the main repo reasonably quickly.

cerveada
cerveada previously approved these changes Jul 19, 2023
Copy link
Contributor

@cerveada cerveada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if it doesn't take too long, it's better to wait for the official release of the plugin.

@wajda
Copy link
Contributor Author

wajda commented Jul 24, 2023

LGTM, but if it doesn't take too long, it's better to wait for the official release of the plugin.

The PR to the "maven-docker-plugin" has been merged. According to the maintainer, a new version is expected to be released by Monday, July 31.
fabric8io/docker-maven-plugin#1694 (comment)

@wajda
Copy link
Contributor Author

wajda commented Jul 28, 2023

The fixed version of the Maven plugin has been published, so I revert my last temporary commit, update the version of the plugin, and merging the PR.

@wajda wajda merged commit 770aa02 into main Jul 28, 2023
@wajda wajda deleted the feature/root-pom-15-multi-arch-builds branch July 28, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker: Multi-arch build
2 participants