Add trace function for matrix types #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiao Zhai <[email protected]>
|
|
|
Thanks for the contribution. Could you kindly add a test for trace() in src/ImathTest/testMatrix.cpp? |
cary-ilm
requested changes
Nov 14, 2022
Signed-off-by: Xiao Zhai <[email protected]>
Signed-off-by: Xiao Zhai <[email protected]>
zhai-xiao
force-pushed
the
matrixTrace
branch
from
66687d7
to
f2b2f6e
Compare
Sure thing, tests added! Also I reverted the error I introduced in ImathMatrixAlgo.h. Thanks for reviewing @cary-ilm |
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 27, 2023
* Add trace function for matrix types Signed-off-by: Xiao Zhai <[email protected]> * Add tests for the matrix trace function Signed-off-by: Xiao Zhai <[email protected]> * Fix issue in extractQuat introduced by incorrect use of matrix trace Signed-off-by: Xiao Zhai <[email protected]> Signed-off-by: Xiao Zhai <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Add trace function for matrix types Signed-off-by: Xiao Zhai <[email protected]> * Add tests for the matrix trace function Signed-off-by: Xiao Zhai <[email protected]> * Fix issue in extractQuat introduced by incorrect use of matrix trace Signed-off-by: Xiao Zhai <[email protected]> Signed-off-by: Xiao Zhai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add trace function for matrix types
Signed-off-by: Xiao Zhai [email protected]