-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std:: to isfinite in ImathFun.cpp #368
Merged
cary-ilm
merged 1 commit into
AcademySoftwareFoundation:main
from
cary-ilm:isfinite-fix
Feb 14, 2024
Merged
Add std:: to isfinite in ImathFun.cpp #368
cary-ilm
merged 1 commit into
AcademySoftwareFoundation:main
from
cary-ilm:isfinite-fix
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The std prefix is correct when using <cmath>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 16, 2024
Signed-off-by: Cary Phillips <[email protected]>
@meshula @cary-ilm Thank you for addressing the issue! There are two other cases in the same file:
So at the moment it still fails:
Once those are fixed in the likewise manner, the build succeeds. |
barracuda156
added a commit
to barracuda156/Imath
that referenced
this pull request
Feb 19, 2024
barracuda156
added a commit
to barracuda156/Imath
that referenced
this pull request
Feb 19, 2024
A follow-up to AcademySoftwareFoundation#368 Fixes: AcademySoftwareFoundation#367 Signed-off-by: Sergey Fedorov <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Feb 20, 2024
A follow-up to #368 Fixes: #367 Signed-off-by: Sergey Fedorov <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 21, 2024
…reFoundation#371) A follow-up to AcademySoftwareFoundation#368 Fixes: AcademySoftwareFoundation#367 Signed-off-by: Sergey Fedorov <[email protected]>
3 tasks
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 27, 2024
…reFoundation#371) A follow-up to AcademySoftwareFoundation#368 Fixes: AcademySoftwareFoundation#367 Signed-off-by: Sergey Fedorov <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Feb 27, 2024
A follow-up to #368 Fixes: #367 Signed-off-by: Sergey Fedorov <[email protected]>
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Mar 3, 2024
## Version 3.1.11 (February 28, 2024) Patch release with small build fix: - Add explicit `std::` namespace for `isfinite` in `ImathFun.cpp` This release also introduces the practice of signing release artifacts via [sigstore](https://www.sigstore.dev). ### Merged Pull Requests * \[[#371](https://github.com/AcademySoftwareFoundation/Imath/pull/371)\] ImathFun.cpp: add std:: to isfinite in remaining cases (#371) * \[[#369](https://github.com/AcademySoftwareFoundation/Imath/pull/369)\] Add workflow to sign release artifacts with Sigstore * \[[#368](https://github.com/AcademySoftwareFoundation/Imath/pull/368)\] Add std:: to isfinite in ImathFun.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully address #367