Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify default color handling in GLSL #1452

Merged

Commits on Aug 16, 2023

  1. Simplify default color handling in GLSL

    This changelist simplifies default color handling in GLSL, making the renderer responsible for generating fallback textures when images are not found on disk, and removing associated dynamic branches in GLSL shader code.
    
    Two advantages of this simplification are:
    - Hydra Storm and other MaterialXGenGlsl integrations can now render materials that reference 1x1 images without needing special-case logic.
    - The render performance of MaterialXGenGlsl shaders that reference images is slightly improved, as dynamic branches exact a performance cost in some situations.
    
    This new logic doesn't yet handle color space differences between missing images and default colors, and we should address this across languages in a future improvement.
    jstone-lucasfilm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    85e9e45 View commit details
    Browse the repository at this point in the history
  2. Extend change to MSL

    jstone-lucasfilm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    44d2f00 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    299e191 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    a8a81f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2df3ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc2db6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6484a63 View commit details
    Browse the repository at this point in the history