Fix edge case in HW shader generation for transform nodes #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the `TransformXXXNodeGlsl` and `TransformXXXNodeMsl` classes into a `HwTransformNode` which has 3 subclasses, `HwTransformVectorNode`, `HwTransformPointNode`, and `HwTransformNormalNode`, all of which can be configured by overriding the virtual methods of `HwTransformNode`.
madmann91
force-pushed
the
fix_crash_1425
branch
from
3e3303c
to
ccefb38
Compare
kwokcb
reviewed
Oct 12, 2023
- Use static strings for `fromspace` and `tospace` - Create helper method `getValueString` on `ShaderPort`.
kwokcb
reviewed
Oct 13, 2023
jstone-lucasfilm
changed the title
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
kwokcb
approved these changes
Oct 14, 2023
jstone-lucasfilm
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Great work, @madmann91, and this is a very elegant solution to the posted issue!
jstone-lucasfilm
merged commit a62a468
into
AcademySoftwareFoundation:main
31 checks passed
JGamache-autodesk
added a commit
to Autodesk/maya-usd
that referenced
this pull request
Jan 12, 2024
A transform node with empty space values will cause the shadergen to crash. This has been fixed in future MaterialX 1.38.9 by introducing ShaderPort::getValueString() in AcademySoftwareFoundation/MaterialX#1560 We have backported that fix in local copies of the transform node C++ implementations in order to prevent crashing with the current versions of MaterialX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the
TransformXXXNodeGlslandTransformXXXNodeMslclasses into aHwTransformNodewhich has 3 subclasses,HwTransformVectorNode,HwTransformPointNode, andHwTransformNormalNode, all of which can be configured by overriding the virtual methods ofHwTransformNode.Fixes #1425