Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MDL implementation of mx_hsvtorgb #1584

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix MDL implementation of mx_hsvtorgb #1584

merged 1 commit into from
Oct 28, 2023

Conversation

pablode
Copy link
Contributor

@pablode pablode commented Oct 26, 2023

This fixes #1583.

jstone-lucasfilm
jstone-lucasfilm approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, thanks @pablode!

@jstone-lucasfilm jstone-lucasfilm merged commit 578118d into AcademySoftwareFoundation:main Oct 28, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstone-lucasfilm jstone-lucasfilm jstone-lucasfilm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MDL implementation of mx_hsvtorgb is incorrect
2 participants
@pablode @jstone-lucasfilm