Fix swizzle edge cases in version upgrade #1957
Merged
Commits on Aug 1, 2024
-
-
Signed-off-by: Jonathan Stone <[email protected]>
Commits on Aug 2, 2024
Commits on Aug 3, 2024
Commits on Aug 6, 2024
-
In this case, I think it's fine to omit the new unit test for these specific swizzle patterns, following the approach we use for validating earlier version upgrades. If there are production examples of materials leveraging these swizzle patterns, it would be fine to include them in our test suite with other version upgrade examples: https://github.com/AcademySoftwareFoundation/MaterialX/tree/main/resources/Materials/TestSuite/stdlib/upgrade Signed-off-by: Jonathan Stone <[email protected]>
-
Signed-off-by: Jonathan Stone <[email protected]>
-
-
Signed-off-by: Jonathan Stone <[email protected]>
Commits on Aug 7, 2024
Commits on Aug 8, 2024
-
Signed-off-by: Jonathan Stone <[email protected]>
-
Signed-off-by: Jonathan Stone <[email protected]>
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.