Fix atan2 argument order for HLSL (#1712)

Signed-off-by: Doug Walker <[email protected]> Signed-off-by: Doug Walker <[email protected]>
AcademySoftwareFoundation · Oct 28, 2022 · 8a93946 · 8a93946
1 parent 3ffcc3f
commit 8a93946
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/OpenColorIO/GpuShaderUtils.cpp b/src/OpenColorIO/GpuShaderUtils.cpp
@@ -1087,8 +1087,10 @@ std::string GpuShaderText::atan2(const std::string & y,
         }
         case GPU_LANGUAGE_HLSL_DX11:
         {
-            // note: operand order is swapped in HLSL
-            kw << "atan2(" << x << ", " << y << ")";
+            // note: Various internet sources claim that the x & y arguments need to be
+            // swapped for HLSL (relative to GLSL).  However, recent testing on Windows
+            // has revealed that the argument order needs to be the same as GLSL.
+            kw << "atan2(" << y << ", " << x << ")";
             break;
         }
         case LANGUAGE_OSL_1: