Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support minizip-ng 4.0 #1800

Closed
MehdiChinoune opened this issue May 20, 2023 · 4 comments
Closed

support minizip-ng 4.0 #1800

MehdiChinoune opened this issue May 20, 2023 · 4 comments

Comments

@MehdiChinoune
Copy link

The new version has broken API.

@Future998
Copy link

Yes, the build of the latest version of opencolorio (2.2.1) with the new version of minizip-ng (4.0.0) broke.

@Pro-pra
Copy link

Pro-pra commented May 30, 2023

Yes minizip-ng say:

Functions ending in _create( will no longer accept a first parameter. This forces a single way to get a pointer to new object and is more likely to result in a check of its value.

i see example in this zlib-ng/minizip-ng@217adc9

- mz_zip_create(&zip_handle);
+ zip_handle = mz_zip_create();

@brad0
Copy link
Contributor

brad0 commented Jun 17, 2023

I added a PR here.

#1806

@brad0
Copy link
Contributor

brad0 commented Aug 12, 2023

This has been fixed with bdc4cd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants