-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for minizip-ng 4 API #1806
Add support for minizip-ng 4 API #1806
Conversation
Seeing how this breaks at the same position as #1808 it would appear the code is broken elsewhere. Since PyColorSpaceSet.cpp was changed recently this seems like the likely culprit. |
#1762 suffers from the same CIS issue now. |
@brad0 you missed one call, could you add that? diff -Naurw a/src/apps/ocioarchive/main.cpp b/src/apps/ocioarchive/main.cpp
--- a/src/apps/ocioarchive/main.cpp
+++ b/src/apps/ocioarchive/main.cpp
@@ -235,7 +235,11 @@
}
std::string path = args[0];
+#if MZ_VERSION_BUILD >= 040000
+ reader = mz_zip_reader_create();
+#else
mz_zip_reader_create(&reader);
+#endif
struct tm tmu_date;
err = mz_zip_reader_open_file(reader, path.c_str()); |
Signed-off-by: Brad Smith <[email protected]>
Thanks. I was wondering why I did not notice this at first but we do not build the apps with the OpenBSD port. |
ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for the contribution @brad0 and sorry for the latency.
Thank you. |
ping. |
Thank you. |
Signed-off-by: Brad Smith <[email protected]> Co-authored-by: Rémi Achard <[email protected]> Co-authored-by: Doug Walker <[email protected]> Signed-off-by: Doug Walker <[email protected]>
No description provided.