-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python copy support #1575
Python copy support #1575
Conversation
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Remi, this is super useful. Seems to work as expected.
[Question] Only the |
Good question. It seems that in our context, the difference between Python Here is the pybind11 doc and a quote from the copy module doc:
|
There is a major semantic difference between I think that adding the Python |
I can remove it, it will go back to produce a segfault as before if we are fine with it. Edit: I removed the |
Signed-off-by: Rémi Achard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only made some comments for code improvements.
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
* Add deepcopy support for object with createEditableCopy method Signed-off-by: Rémi Achard <[email protected]> * Minor fixes Signed-off-by: Rémi Achard <[email protected]> * Removing python shallow copy method Signed-off-by: Rémi Achard <[email protected]> * Update comment and formating Signed-off-by: Rémi Achard <[email protected]> * Testing COnfig FileRules deepCopy Signed-off-by: Rémi Achard <[email protected]> * Add comment for ConfigTest Signed-off-by: Rémi Achard <[email protected]> Co-authored-by: Patrick Hodoul <[email protected]>
* Add deepcopy support for object with createEditableCopy method Signed-off-by: Rémi Achard <[email protected]> * Minor fixes Signed-off-by: Rémi Achard <[email protected]> * Removing python shallow copy method Signed-off-by: Rémi Achard <[email protected]> * Update comment and formating Signed-off-by: Rémi Achard <[email protected]> * Testing COnfig FileRules deepCopy Signed-off-by: Rémi Achard <[email protected]> * Add comment for ConfigTest Signed-off-by: Rémi Achard <[email protected]> Co-authored-by: Patrick Hodoul <[email protected]> Co-authored-by: Rémi Achard <[email protected]>
* Add deepcopy support for object with createEditableCopy method Signed-off-by: Rémi Achard <[email protected]> * Minor fixes Signed-off-by: Rémi Achard <[email protected]> * Removing python shallow copy method Signed-off-by: Rémi Achard <[email protected]> * Update comment and formating Signed-off-by: Rémi Achard <[email protected]> * Testing COnfig FileRules deepCopy Signed-off-by: Rémi Achard <[email protected]> * Add comment for ConfigTest Signed-off-by: Rémi Achard <[email protected]> Co-authored-by: Patrick Hodoul <[email protected]>
* Python copy support (#1575) * Add deepcopy support for object with createEditableCopy method Signed-off-by: Rémi Achard <[email protected]> * Minor fixes Signed-off-by: Rémi Achard <[email protected]> * Removing python shallow copy method Signed-off-by: Rémi Achard <[email protected]> * Update comment and formating Signed-off-by: Rémi Achard <[email protected]> * Testing COnfig FileRules deepCopy Signed-off-by: Rémi Achard <[email protected]> * Add comment for ConfigTest Signed-off-by: Rémi Achard <[email protected]> Co-authored-by: Patrick Hodoul <[email protected]> * Unit test fix Signed-off-by: Patrick Hodoul <[email protected]> Co-authored-by: Rémi Achard <[email protected]>
This PR addresses #1434 adding
copy
/deepcopy
(same implementation) for OCIO objects having C++createEditableCopy()
methods. It also fix the typo reported in #1540.