Improve iridas_cube parsing speed #1630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating long processor creation time (> 3.5sec), I noticed
iridas_cube
was really slow compared tospi3d
for 3DLUT loading (on my system around 900ms and 250ms respectively for a 65x65x65 LUT). This brings it to similar performance.Here is a benchmark using a 65x65x65 .cube 3DLUT, processor creation time (mean of 3 runs
ocioperf --transform
):