Adsk contrib - Fix issues when building OCIO with MS Visual Studio 2022 #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cedrik Fuoco <[email protected]>
remia
reviewed
May 17, 2022
remia
reviewed
May 17, 2022
|
Thanks @cedrik-fuoco-adsk, when the Linux issue has been resolved, I would suggest we merge this one quickly as the CI seem to be broken on other PR for Windows which is fixed here. Probably some update to the Windows runners (although they are not using VS 2022). |
Signed-off-by: Cedrik Fuoco <[email protected]>
…wareFoundation#1634) Signed-off-by: Cedrik Fuoco <[email protected]>
…for the Glew fix. Signed-off-by: Cedrik Fuoco <[email protected]>
Signed-off-by: Cedrik Fuoco <[email protected]>
Signed-off-by: Cedrik Fuoco <[email protected]>
remia
approved these changes
May 18, 2022
doug-walker
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All issues were discovered when trying to configure and build OCIO on Windows using Microsoft Visual Studio 2022.
Pybind11 has an issue with Microsoft Visual Studio 2022, FindGlew from CMake has a bug around setting GLEW_INCLUDE_DIRS correctly and OpenImageIO as some warnings that get flagged as error. Since those warning are in the OCIO apps, we decided that I would be ok to ignore them temporarily.
Content overview:
Updating Pybind11 to the latest version as Pybind11 <2.9.0 has issues with Microsoft Visual Studio 2022.
Add fix to make sure that GLEW_INCLUDE_DIRS is set correctly.
Ignoring warnings (C4267 and C4244) temporarily in ociolutimage, ocioconvert and oiiohelpers
Reference issue #1634.
Signed-off-by: Cedrik Fuoco [email protected]