Baking crosstalk and NamedTransform support fix #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-walker
approved these changes
Sep 28, 2022
cedrik-fuoco-adsk
approved these changes
Oct 19, 2022
|
Tagging as draft while I investigate the issue with NamedTransform. Edit: now ready for review again, NamedTransform should work as Baker's shaperSpace (but not as input or target space). |
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
Signed-off-by: Rémi Achard <[email protected]>
remia
force-pushed
the
fix-baker-shaperspace-crosstalk
branch
from
9fa04fa
to
587be67
Compare
cedrik-fuoco-adsk
approved these changes
Oct 27, 2022
doug-walker
approved these changes
Oct 27, 2022
remia
changed the title
michdolan
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1598, fix the crosstalk shaper space check making sure we use the optimised processor to allow typical collapse of matrices. There is another issue related to the use of
NamedTransformas shaper space which appear to not work currently because we are usingLookTransformwhich doesn't support these.