Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk Contrib - Improve Windows batch files to find installed Visual Studio location #1980

Conversation

cozdas
Copy link
Collaborator

@cozdas cozdas commented May 29, 2024

  • Instead of assuming a hard-coded visual studio installation path, we're now using the vswhere.exe tool that the visual studio installs in every system. This removes the necessity to specify the msvc path in the command line if visual studio was not installed into the default path. Option to override is still possible as before.

…e're now using the vswhere.exe tool that the visual studio installs in every system. This removes the necessity to specify the msvc path in the command line if visual studio was not installed into the default path. Option to override is still possible as before.

Signed-off-by: cuneyt.ozdas <[email protected]>
@cozdas cozdas requested a review from doug-walker May 29, 2024 18:49
Copy link

linux-foundation-easycla bot commented May 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@doug-walker doug-walker changed the title Improve Windows batch files to find installed Visual Studio location. Adsk Contrib - Improve Windows batch files to find installed Visual Studio location May 30, 2024
Copy link
Contributor

@KelSolaar KelSolaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doug-walker doug-walker merged commit 62d3557 into AcademySoftwareFoundation:main Sep 12, 2024
25 checks passed
@doug-walker doug-walker deleted the cozdas/MSVC_FindImprovement branch September 12, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants