Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk Contrib - Modify half-domain LUT1D GPU shader to improve zero handling #1981

Merged

Conversation

doug-walker
Copy link
Collaborator

Made a small improvement in the GPU shader for half-domain LUT1D ops.

The half-domain LUT1D is structured like a half-float and so it has two entries for zero (positive and negative). The shader was looking up positive 0 at the negative 0 entry. Normally, a half-domain LUT1D should set +0 and -0 to the same value, so in practice this should not be an issue, but it is now more technically correct. I added a unit test to verify this (it failed prior to the shader adjustment, the GPU matched the CPU at -0 rather than +0).

In addition, I clarified the code that scales denorms in that shader. This is numerically equivalent but might be somewhat clearer to read.

Finally, I added an unrelated but potentially useful unit test to verify that the cacheID of a Processor containing a LUT3D changes if one of the LUT entries changes.

@doug-walker doug-walker requested a review from cozdas August 9, 2024 21:54
Copy link
Collaborator

@cozdas cozdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@doug-walker doug-walker merged commit 9864d75 into AcademySoftwareFoundation:main Sep 5, 2024
25 checks passed
@doug-walker doug-walker deleted the bug/lut1d_neg_zero branch September 5, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants