Skip to content

Commit

Permalink
Extracted CMX3600 adapter and related sample data and tests (#1487)
Browse files Browse the repository at this point in the history
* Removed the cmx_3600 adapter
* Removed sample data only used by the cmx_3600 adapter
* Add "extract_adapters" to CI triggers
* otioz test called for an edl we removed. Replaced with an otio file
* Converted screening_example.edl to screening_example.otio and used it in tests
* Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted
* Autogenerated docs for CMX3600 removed

Signed-off-by: apetrynet <[email protected]>
  • Loading branch information
apetrynet authored and reinecke committed Oct 6, 2023
1 parent f11964b commit 275435b
Show file tree
Hide file tree
Showing 32 changed files with 466 additions and 4,489 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import opentimelineio as otio

SAMPLE_DATA_DIR = os.path.join(os.path.dirname(__file__), "sample_data")
SCREENING_EXAMPLE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.edl")
SCREENING_EXAMPLE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.otio")
BASELINE_PATH = os.path.join(SAMPLE_DATA_DIR, "screening_example.ma")
SETATTR_TO_CHECK = (".ef", ".sf", ".sn", ".se", ".ssf")

Expand Down
50 changes: 0 additions & 50 deletions docs/tutorials/otio-plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,56 +33,6 @@ Adapter plugins convert to and from OpenTimelineIO.
[Tutorial on how to write an adapter](write-an-adapter).


### cmx_3600

```
OpenTimelineIO CMX 3600 EDL Adapter
```

*source*: `opentimelineio/adapters/cmx_3600.py`


*Supported Features (with arguments)*:

- read_from_string:
```
Reads a CMX Edit Decision List (EDL) from a string.
Since EDLs don't contain metadata specifying the rate they are meant
for, you may need to specify the rate parameter (default is 24).
By default, read_from_string will throw an exception if it discovers
invalid timecode in the EDL. For example, if a clip's record timecode
overlaps with the previous cut. Since this is a common mistake in
many EDLs, you can specify ignore_timecode_mismatch=True, which will
supress these errors and attempt to guess at the correct record
timecode based on the source timecode and adjacent cuts.
For best results, you may wish to do something like this:
Example:
>>> try:
... timeline = otio.adapters.read_from_string("mymovie.edl", rate=30)
... except EDLParseError:
... print('Log a warning here')
... try:
... timeline = otio.adapters.read_from_string(
... "mymovie.edl",
... rate=30,
... ignore_timecode_mismatch=True)
... except EDLParseError:
... print('Log an error here')
```
- input_str
- rate
- ignore_timecode_mismatch
- write_to_string:
- input_otio
- rate
- style
- reelname_len





### fcp_xml

```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@
"filepath" : "otiod.py",
"suffixes" : ["otiod"]
},
{
"OTIO_SCHEMA" : "Adapter.1",
"name" : "cmx_3600",
"filepath" : "cmx_3600.py",
"suffixes" : ["edl"]
},
{
"OTIO_SCHEMA" : "Adapter.1",
"name" : "svg",
Expand Down
Loading

0 comments on commit 275435b

Please sign in to comment.