Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OTIO to SVG adapter #1038

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

KarthikRIyer
Copy link
Contributor

Closes #519

Squashed version of #649

@codecov-commenter
Copy link

Codecov Report

Merging #1038 (4664d4a) into master (0682256) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   79.30%   79.30%   -0.01%     
==========================================
  Files         113      113              
  Lines        6098     6102       +4     
==========================================
+ Hits         4836     4839       +3     
- Misses       1262     1263       +1     
Flag Coverage Δ
unittests 79.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ybind11/include/pybind11/detail/type_caster_base.h 64.18% <0.00%> (-0.34%) ⬇️
src/deps/pybind11/include/pybind11/attr.h 76.92% <0.00%> (ø)
src/deps/pybind11/include/pybind11/cast.h 85.03% <0.00%> (ø)
src/deps/pybind11/include/pybind11/detail/init.h 100.00% <0.00%> (ø)
src/deps/pybind11/include/pybind11/detail/common.h 66.66% <0.00%> (ø)
src/deps/pybind11/include/pybind11/pybind11.h 77.83% <0.00%> (+0.07%) ⬆️
src/deps/pybind11/include/pybind11/pytypes.h 81.73% <0.00%> (+0.08%) ⬆️
src/deps/pybind11/include/pybind11/detail/class.h 73.40% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0682256...4664d4a. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a new PR! The CI issues seem cleared up.

@meshula meshula merged commit 8bcec0a into AcademySoftwareFoundation:master Aug 7, 2021
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTIO to SVG adapter
4 participants