AAF Parser - Simplify no longer removes track of all muted clips #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jminor
approved these changes
Oct 13, 2021
Closed
jminor
approved these changes
Oct 16, 2021
|
@jminor Is there a a reason this hasn't been merged yet? |
|
Now that #1175 has landed, we can update the AAF adapter to use the |
|
@andrewmoore-nz and @timlehr how about this instead? #1212 |
|
@andrewmoore-nz do we still need this PR now that your #1277 has landed? |
|
@jminor This is redundant now, so no longer needed. I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug that recently came to my attention, so figured I'd submit a PR to match the change we've put in to our branch for use in Matchbox.
Looks to be an oversight in how the Gap objects are actually being used, as there is absolutely something valuable in that object when it's a muted clip and contains all the information on the clip that is muted.