-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the developer quickstart documentation #1144
Improve the developer quickstart documentation #1144
Conversation
@ThomasWilshaw Do you think the proposed changed would have made your experience better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I've noted a couple of issues.
Yes that's definitely clearer but there's still a few things I don't follow.
Am I right in thinking that if I were to edit the code base in a way that affected both the Python and C++ sections, the best way for me to compile everything and run the tests would be to run I should just clarify I'm not a very experienced dev (and I particularly don't like actually compiling software ;)) so I could just be misunderstanding things or generally no know what I'm doing :) |
* Remove usage of --user flag
@ThomasWilshaw I just pushed an update which hopefully should answer your questions. Let me know if it's still unclear. |
One thing we haven't gotten to is a comprehensive test suite at the C++ level. We are relying on the python bindings to expose problems. If you are developing in the C++ code, you should do a pip install and run the python tests before submitting a PR. It's up to you whether you also do a pip install while you are iterating the C++ code. New C++ PRs are expected to have a C++ based test to go along with them. We will need to add a comprehensive test suite at the C++ level. |
That's defintely a lot clearer thanks. |
* Improve the developer quickstart documentation and remove obsolete instructions. * * Clarification of the different C++ code layers in the repo * Remove usage of --user flag
As note in https://academysoftwarefdn.slack.com/archives/CMQ9J4BQC/p1636760978147000, the developer quickstart documentation is out of date right now.
This PR removes obsolete instructions, adds some more instructions and also use modern methodologies (e.g. call
python -m pip
install ofpip
, don't callpython setup.py
, etc).Hopefully it should be clear enough and the additions I made will help future contributors.