Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage report uploads #1189

Conversation

JeanChristopheMorinPerso
Copy link
Member

I recently noticed that the code coverage report uploads were no more running. The cause was that we forgot to un-bake the GH_COV_OS in the workflow after we release 0.14.0.

@codecov-commenter
Copy link

Codecov Report

Merging #1189 (4ebff50) into main (4d2f668) will decrease coverage by 0.15%.
The diff coverage is 67.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   86.21%   86.06%   -0.16%     
==========================================
  Files         191      191              
  Lines       19047    19215     +168     
  Branches     2104     2291     +187     
==========================================
+ Hits        16422    16537     +115     
- Misses       2079     2125      +46     
- Partials      546      553       +7     
Flag Coverage Δ
unittests 86.06% <67.39%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/py-opentimelineio/opentimelineio/__init__.py 100.00% <ø> (ø)
...-opentimelineio/opentimelineio/console/__init__.py 100.00% <ø> (ø)
tests/test_console.py 92.41% <50.00%> (-1.25%) ⬇️
...neio_contrib/adapters/advanced_authoring_format.py 81.42% <59.28%> (-5.00%) ⬇️
...elineio_contrib/adapters/tests/test_aaf_adapter.py 98.36% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990a54c...4ebff50. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I remember the conversation where we said we would do this, thanks for finding this omission!

@meshula meshula merged commit a79bc1e into AcademySoftwareFoundation:main Jan 9, 2022
jminor pushed a commit that referenced this pull request Feb 11, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the reenable_coverage branch June 8, 2022 00:55
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants