Copy core sample data used by contrib tests into the contrib area to better isolate contrib tests #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better isolate contrib tests such that they can run in a self contained way.
Codecov Report
@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 196 196
Lines 19671 19671
Branches 2308 2308
=======================================
Hits 16937 16937
Misses 2173 2173
Partials 561 561
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jminor
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
This looks great.
The only note I have is unrelated to the change itself. It seems slightly odd that these tests are relying on the EDL adapter to function. It would be cleaner if they only needed OTIO files. That doesn't need to happen now, but could be done later when we split contrib out.
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
This allows the contrib tests to be run in isolation, and sets us up for a future split into a separate repo. Co-authored-by: Robyn Rindge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the contrib tests to such that they can run in a self contained way and allows for a future where they are split out.
This was done to allow testing of the
contrib/opentimelinio_contrib/adapters/testson it's own without the need for assumptions of the current file structure.Reference associated tests.
test_rvsession.py and test_maya_sequencer.py