Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_v2d to support multiple exception types #1279

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

avrata
Copy link
Contributor

@avrata avrata commented Apr 20, 2022

This is to support both imath 2 and 3

As part of vfxreference platform support and imath 2, we need to check for either ValueError or RuntimeError as the exception type changes.

@codecov-commenter
Copy link

Codecov Report

Merging #1279 (c9c996d) into main (0d9fb92) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         196      196           
  Lines       19795    19795           
  Branches     2310     2310           
=======================================
  Hits        17062    17062           
  Misses       2171     2171           
  Partials      562      562           
Flag Coverage Δ
py-unittests 86.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_v2d.py 97.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9fb92...c9c996d. Read the comment docs.

@meshula meshula merged commit 06cdd70 into AcademySoftwareFoundation:main Apr 21, 2022
jminor pushed a commit that referenced this pull request May 2, 2022
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants