-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load entrypoint plugins before builtin and contrib. #1389
Load entrypoint plugins before builtin and contrib. #1389
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 196 196
Lines 19871 19883 +12
Branches 2309 2312 +3
=======================================
+ Hits 17144 17155 +11
Misses 2161 2161
- Partials 566 567 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a6d3d17
to
a09effd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! One question, is there a way we could add a unittest to check the precedence? This file seems to have a lot of tests around this sort of thing.
If the unittesting gets a bit too difficult or hacky to implement, I think we can just call it a CBB since we already weren't testing it.
I'll take a look, I think I can use part of those existing tests and come up with something that isn't too hacky. |
Allows for overriding builtin plugins via entrypoint method. Signed-off-by: Mark Reid <[email protected]>
a09effd
to
6a7397e
Compare
Signed-off-by: Mark Reid <[email protected]>
95a6d4c
to
7e513ec
Compare
I added a unit test, please take a look when you have the time |
@ssteinbach does this conflict with the downgrader PR at all? Do you care if this lands before/after that one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for adding the test!
Not an issue. The only file in common is in manifest.py and it isn't a conflicting change. Go for it! |
@jminor do you want to land this before or after the next release? (IE do you want to land it at the beginning of the next cycle or at the end of this one) |
It would be especially helpful for people working on extracting contrib adapters if it was in the next wheel release. 🙂 It would allow running unit test against a wheel, at least for me, instead of having to compile OTIO everytime i run CI. saves a lot time/cycles. |
…areFoundation#1389) * Load entrypoint plugins before builtin and contrib in order to allow overriding builtin plugins. Signed-off-by: Mark Reid <[email protected]> Signed-off-by: Michele Spina <[email protected]>
This pull request is meant to assist the moving contrib adapters to external repos.
You can use
$OTIO_PLUGIN_MANIFEST_PATH
to override a contrib adapter, however this can be inflexible and difficult to test your adapter when you install it.Being able to use a stock install of OTIO also means you don't have to manage pull requests for 2 repos at the same time when starting to move a contrib adapter.
This issue has been mentioned in #1348