Add implementation of to_nearest_timecode #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 79.95% 79.89% -0.06%
==========================================
Files 197 197
Lines 21879 21900 +21
Branches 4342 4351 +9
==========================================
+ Hits 17494 17498 +4
- Misses 2252 2269 +17
Partials 2133 2133
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
meshula
approved these changes
Apr 5, 2024
…version of timecode from a rate using the closest valid time code rate. Signed-off-by: Anton Marini <[email protected]>
Signed-off-by: Anton Marini <[email protected]>
Signed-off-by: Anton Marini <[email protected]>
vade
force-pushed
the
fixes/to_nearest_timecode
branch
from
810b27b
to
1207631
Compare
|
Thanks for your patience. DCO Sign off passed. I'll try to keep that in mind in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of
to_nearest_timecodewhich makes approximate conversion of timecode from a rate using the closest valid time code rate.This is intended to fix various downstream adaptor hiccups where source material might be variable frame rate, or close but not quite an exact SMPTE timecode.
Link the Issue(s) this Pull Request is related to.
#830
Summarize your change.
This PR does not directly fix the FCP_XML adaptor, but rather isolates changes to OTIO core and exposes a
to_nearest_timecodewith the same method signature asto_timecode.This is intended to act as a entry point for changes to other adaptors if deemed a valid approach
Reference associated tests.
No new tests just yet.