Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed freeze script github yaml parsing and unfroze the ci versions #1726

Conversation

reinecke
Copy link
Collaborator

The freeze CI versions script had broken with an update to the GitHub documentation formatting. This update uses a slightly more markdown-aware approach to extract the needed info.

Also addressed minor escaping issue in Makefile I'd discovered while cutting the 0.16.0 release.

@reinecke reinecke force-pushed the post-beta-16-unfreeze-ci-versions branch 2 times, most recently from 71ee6c1 to 6746f2b Compare April 12, 2024 05:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.71%. Comparing base (c0e97b0) to head (62e7a4e).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   84.11%   81.71%   -2.41%     
==========================================
  Files         198      176      -22     
  Lines       22241    12315    -9926     
  Branches     4687     3022    -1665     
==========================================
- Hits        18709    10063    -8646     
+ Misses       2610     1715     -895     
+ Partials      922      537     -385     
Flag Coverage Δ
py-unittests 81.71% <ø> (-2.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588ff5b...62e7a4e. Read the comment docs.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, this rearranges how the non-latest versions are fetched AFAICT? I had one question in there on the Makefile, otherwise seems fine.

Makefile Outdated Show resolved Hide resolved
maintainers/freeze_ci_versions.py Outdated Show resolved Hide resolved
maintainers/freeze_ci_versions.py Outdated Show resolved Hide resolved
@ssteinbach ssteinbach added this to the Public Beta 17 milestone Apr 18, 2024
@reinecke reinecke force-pushed the post-beta-16-unfreeze-ci-versions branch from d4c3838 to 863079e Compare June 24, 2024 21:35
reinecke and others added 4 commits June 24, 2024 14:56
…Also addressed minor escaping issue in Makefile

Signed-off-by: Eric Reinecke <[email protected]>
Co-authored-by: Daniel Flehner Heen <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
@reinecke reinecke force-pushed the post-beta-16-unfreeze-ci-versions branch from 863079e to 62e7a4e Compare June 24, 2024 21:56
@github-actions github-actions bot added the ci label Jun 24, 2024
Copy link
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reinecke reinecke merged commit 50f4bc8 into AcademySoftwareFoundation:main Jun 24, 2024
56 checks passed
@reinecke reinecke deleted the post-beta-16-unfreeze-ci-versions branch June 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants