-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed freeze script github yaml parsing and unfroze the ci versions #1726
Fixed freeze script github yaml parsing and unfroze the ci versions #1726
Conversation
71ee6c1
to
6746f2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 84.11% 81.71% -2.41%
==========================================
Files 198 176 -22
Lines 22241 12315 -9926
Branches 4687 3022 -1665
==========================================
- Hits 18709 10063 -8646
+ Misses 2610 1715 -895
+ Partials 922 537 -385
Flags with carried forward coverage won't be shown. Click here to find out more. see 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, this rearranges how the non-latest versions are fetched AFAICT? I had one question in there on the Makefile, otherwise seems fine.
d4c3838
to
863079e
Compare
…Also addressed minor escaping issue in Makefile Signed-off-by: Eric Reinecke <[email protected]>
Co-authored-by: Daniel Flehner Heen <[email protected]> Signed-off-by: Eric Reinecke <[email protected]>
Co-authored-by: Stephan Steinbach <[email protected]> Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
863079e
to
62e7a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The freeze CI versions script had broken with an update to the GitHub documentation formatting. This update uses a slightly more markdown-aware approach to extract the needed info.
Also addressed minor escaping issue in Makefile I'd discovered while cutting the 0.16.0 release.