AAF Reader: simplify source_range and available_range in transcribe() of SourceClip #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
=========================================
- Coverage 88.82% 88.8% -0.02%
=========================================
Files 68 68
Lines 7394 7399 +5
=========================================
+ Hits 6568 6571 +3
- Misses 826 828 +2
Continue to review full report at Codecov.
|
freesonluxo
changed the title
|
Awesome, thanks! |
ssteinbach
pushed a commit
to ssteinbach/OpenTimelineIO
that referenced
this pull request
Jun 20, 2019
… of SourceClip (AcademySoftwareFoundation#517) * _transcribe() now stores the chain of parents instead of just one * Reimplementation of source_range and available_range logic when transcribing aaf -> otio * Adding comments to explain whats going on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During _transcribe(), we store just one parent. This is great, but it would be even better to have the entire parent chain available - both for debugging and perhaps for logic. I believe there is at least one if statement which really wants to say "am I a clip in the CompositionMob", which would now be made a lot easier by this change.