AAF Writer: To get the edit rate, look at the first "child" not the first "clip". #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is is necessary for tracks with all gaps
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 88.81% 88.82% +<.01%
==========================================
Files 68 68
Lines 7388 7394 +6
==========================================
+ Hits 6562 6568 +6
Misses 826 826
Continue to review full report at Codecov.
|
ssteinbach
requested changes
May 22, 2019
|
That unit test you added could be useful in the future to poke at simplification stuff as well. Thanks! |
ssteinbach
pushed a commit
to ssteinbach/OpenTimelineIO
that referenced
this pull request
Jun 20, 2019
…irst "clip". (AcademySoftwareFoundation#518) * To get the edit rate, look at the first child, not the first clip. This is necessary for tracks with all gaps * Adding a test for just gaps.otio file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change is to address cases where the track has all gaps and does not have proper "clip"s