-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.5->3.7 #526
Python 3.5->3.7 #526
Conversation
See #516 |
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
======================================
Coverage 88.8% 88.8%
======================================
Files 68 68
Lines 7399 7399
======================================
Hits 6571 6571
Misses 828 828 Continue to review full report at Codecov.
|
Set up a pull request from me to you. Two warnings: First, a deprecation warning:
Easily fixable, and since VFX platform won't be targeting for 3.8, probably no need to worry about it for a long while. Still might be nice to clean it up. Second - this wouldn't pass tests (at least for me) right away.
I was hitting this even though pyaaf2 is installed in my venv. So to make it happy, I explicitly added pyaaf2 to tox, even though that shouldn't be necessary. Additionally, I did a pip install with PySide 2 in the new Python37 virtual environment and view still works fine from quick tests. Outside of that, once you accept my PR into your branch, this should be good to go, from what I can see. |
Update tox and manifest in preparation for Python37
@boredstiff I merged your PR. good call! |
Move from python 3.5 to python 3.7