Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmx3600 reverse and dissolve fixes #687

Conversation

reinecke
Copy link
Collaborator

  • Addressed an issue where the speed change regex wouldn't properly parse reversed clips
  • Fixed assumption that clips used in a transition would always be continuous with the clips before and after the transition

Additional notes:
This fix works but is a touch messy. The parser is structured in a way that OTIO Clips are created before all the metadata that might apply to them has been parsed and some of the transition handling is a bit band-aidy as a result. We may start thinking about how to refactor a bit to make the code a bit cleaner for these situations.

@reinecke reinecke requested a review from jminor May 6, 2020 23:38
Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the comment and really small note about one of the functions. Thanks!

…hould be a boolean False in the CMX adapter.
@reinecke
Copy link
Collaborator Author

Good notes! Updated with clarifications.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #687 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   81.72%   81.88%   +0.15%     
==========================================
  Files          72       72              
  Lines        2731     2755      +24     
==========================================
+ Hits         2232     2256      +24     
  Misses        499      499              
Flag Coverage Δ
#py27 81.86% <ø> (+0.15%) ⬆️
#py36 81.86% <ø> (+0.15%) ⬆️
#py37 81.86% <ø> (+0.15%) ⬆️
Impacted Files Coverage Δ
src/opentime/timeRange.h 100.00% <0.00%> (ø)
...imelineio/opentime-bindings/opentime_timeRange.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234b3f3...32b84e3. Read the comment docs.

@reinecke reinecke merged commit 76880ba into AcademySoftwareFoundation:master Jul 3, 2020
@ssteinbach ssteinbach added this to the Public Beta 13 milestone Aug 19, 2020
@reinecke reinecke deleted the feature/CMX3600_reverse_and_dissolve_fixes branch August 25, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants